Simplify codegen for is-expressions #65845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Community
alrz
commented
Dec 8, 2022
| (true, false) => LowerTest(testNode.Test), | ||
| (false, true) => _factory.Not(LowerTest(testNode.Test)), | ||
| (null, true) => _factory.LogicalOr(_factory.Not(LowerTest(testNode.Test)), whenTrue), | ||
| (null, false) => _factory.LogicalAnd(LowerTest(testNode.Test), whenTrue), |
There was a problem hiding this comment.
Couple of issues with this approach:
- This expression is deep on the right-hand-side and emitter generates a different (worse) code for that.
- There a chance to produce duplicated checks because the entire graph is inlined. (no test coverage there)
- This should be able to incorporate switch optimizations: Emit switch for suitable 'or' patterns #45679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55334, #59615
Didn't update the baseline just yet because this results in slightly worse codegen in a few cases.